feat: lookup manifest file size #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2590 +/- ##
===========================================
- Coverage 85.33% 84.86% -0.48%
===========================================
Files 737 738 +1
Lines 118030 119148 +1118
===========================================
+ Hits 100724 101109 +385
- Misses 17306 18039 +733 |
QuenKar
force-pushed
the
feat/manifest-file-size
branch
from
fbf9197 to
bd8989f
Compare
|
After discussing with @evenyag , we decide to only calculate manifest size from the latest checkpoint, the files'version <= latest checkpoint will not be included.
|
evenyag
reviewed
Oct 16, 2023
Co-authored-by: Yingwen <[email protected]>
QuenKar
force-pushed
the
feat/manifest-file-size
branch
from
e2068ef to
33ae485
Compare
evenyag
reviewed
Oct 18, 2023
evenyag
reviewed
Oct 19, 2023
evenyag
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
HashMap<String, u64>to keep track for every manifest file size inManifestObjectStore.RegionManifestManager::manifest_size()to get manifest files size.Checklist
Refer to a related PR or issue link (optional)
#2551